Skip to:
Content

BuddyPress.org

Opened 11 years ago

Closed 11 years ago

#7002 closed defect (bug) (fixed)

background-image: url(); on member pages without a cover image

Reported by: mahadri Owned by: hnla
Priority: normal Milestone: 2.6
Component: Members Version: 2.5.0
Severity: normal Keywords: has-patch
Cc:

Description (last modified by hnla)

If cover image is deleted, the array key is isset() and we will render an empty style background: url();, we need to check if array key value is empty.

Attachments (1)

cover-image-empty-instead-of-isset.diff​ (815 bytes ) - added by mahadri 11 years ago.

Download all attachments as: .zip

Change History (5)

@mahadri
11 years ago

#1 @hnla
11 years ago

  • Milestone Awaiting Review → 2.6

Confirmed - good catch.

Should we not do both isset() && !empty() ?

#2 @hnla
11 years ago

  • Description modified (diff)

#3 @boonebgorges
11 years ago

! empty() implies isset() (and != 0). No need to do both.

#4 @hnla
11 years ago

  • Owner set to hnla
  • Resolution → fixed
  • Status new → closed

In 10691:

Update groups cover image background check to use empty() not isset()
Prevents an empty background url being generated if user deletes cover image.

Fixes #7002 props mahadri

Note: See TracTickets for help on using tickets.