Improve validation in BP_XProfile_Field_Type->is_valid()

[dcavins]

When checking against a set of whitelisted values, the foreach in is_valid() doesn't break when it encounters an invalid value. Instead, it returns the validity of the last value in the array.

[dcavins]

Break if any of the values in the array are not whitelisted.

[DJPaul]

:D

[dcavins]

Ha ha, this is like groundhog day. Yes, there should be tests. :)

[DJPaul]

Specifically, the test needs to answer why the current tests for the XProfile Field Types do not catch this problem -- are those tests badly written? etc.

[dcavins]

Break if any of the values in the array are not whitelisted. Adds unit test updates.

[DJPaul]

@dcavins are you intending this for 2.5 or not? If so, you need to commit it on Monday.

[DJPaul]

If you attach a patch to a ticket, please move it to the active milestone, or it'll probably get overlooked. :)

[dcavins]

In 10592:

Profile: Improve validation in is_valid().

When checking a submitted array of values,
ensure that the foreach breaks when an
invalid value is encountered. Previously,
the foreach returned the validity of the
last element in the array.

Also update unit tests so that invalid values
appear in various positions in the array of
values to check.

Fixes #6884.

[dcavins]

Thanks @DJPaul . I wasn't thinking this was important enough to slip in after the first beta. But, it's also minor enough that slipping it in is no big deal. Thanks for the nudge.