Skip to:
Content

BuddyPress.org

Opened 4 years ago

Closed 3 years ago

#6876 closed enhancement (fixed)

Accessibility: Bump heading in members/single/profile/change-cover-image.php

Reported by: mercime Owned by: mercime
Milestone: 2.7 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch has-screenshots
Cc: roger@…

Description (last modified by mercime)

Basic rationale: see #6871

Current headings:
<h1>Name</h1>
<h2>username</h2>
change-cover-image.php
<h4>Change Cover Image</h4> => <h2> ... </h2>

Attachments (8)

6876.patch (1.5 KB) - added by mercime 4 years ago.
2010.png (9.1 KB) - added by mercime 4 years ago.
2016.png (11.3 KB) - added by mercime 4 years ago.
2015.png (10.7 KB) - added by mercime 4 years ago.
2014.png (9.3 KB) - added by mercime 4 years ago.
2013.png (11.0 KB) - added by mercime 4 years ago.
2012.png (9.0 KB) - added by mercime 4 years ago.
6876.2.patch (529 bytes) - added by mercime 4 years ago.
Patch for heading bump only

Download all attachments as: .zip

Change History (18)

@mercime
4 years ago

@mercime
4 years ago

@mercime
4 years ago

@mercime
4 years ago

@mercime
4 years ago

@mercime
4 years ago

@mercime
4 years ago

#1 @mercime
4 years ago

  • Keywords has-patch has-screenshots added

Attached patch bumps the heading in the Change Cover Image screen with minimal style support.

Attached before & after screenshots of the screen in the following themes:

  • Twenty Ten
  • Twenty Sixteen
  • Twenty Fifteen
  • Twenty Fourteen
  • Twenty Thirteen
  • Twenty Twelve

#2 @DJPaul
4 years ago

  • Keywords changed from has-patch has-screenshots to has-patch, has-screenshots
  • Milestone changed from Awaiting Review to 2.6

@mercime
4 years ago

Patch for heading bump only

#3 @mercime
4 years ago

In 10659:

Accessibility: Bump heading in change-cover-image.php.

See #6876.

#4 @rogercoathup
4 years ago

  • Cc roger@… added
  • Keywords changed from has-patch, has-screenshots to has-patch has-screenshots

Guys (@boonebgorges @jjj @djpaul) this sounds like an absolute disaster -- if I'm reading this correctly, it's going to break the styling of lots of existing sites if we upgrade BuddyPress.

Our sites are styled based on the current heading items.

At the best, it's going to involve considerable re-styling of existing sites. At worst, there will be end clients / users out there who've had sites built, and are not developers who can fix the problems this is going to introduce.

Is the plan to stop people upgrading to 2.6?

If you are going to change front end elements, do it in a new set of templates, not breaking the existing ones. Just as WP does -- where they bring out a new default theme each year.

Obviously, this feedback applies to all this set of related commits, not just this one.

Last edited 4 years ago by rogercoathup (previous) (diff)

#5 @mercime
4 years ago

  • Description modified (diff)

#6 @mercime
3 years ago

In 10737:

Revert heading bump in members/single/profile/change-cover-image.php.

Complete set of heading fixes for all templates will be addressed
in the next dev cycle.

See #6876.

#7 @mercime
3 years ago

  • Milestone changed from 2.6 to Future Release

#8 @DJPaul
3 years ago

  • Component changed from General - UX/UI to Core

#9 @mercime
3 years ago

  • Milestone changed from Future Release to 2.7

Will be uploading new patch for this.

#10 @mercime
3 years ago

  • Owner set to mercime
  • Resolution set to fixed
  • Status changed from new to closed

In 10963:

Accessibility: Bump heading in members change-cover-image.php.

Fixes #6876.

Note: See TracTickets for help on using tickets.