Accessibility: Bump heading in members/single/profile/change-cover-image.php

[mercime]

Basic rationale: see #6871

Current headings:
<h1>Name</h1>
<h2>username</h2>
change-cover-image.php
<h4>Change Cover Image</h4> => <h2> ... </h2>

[mercime]

Attached patch bumps the heading in the Change Cover Image screen with minimal style support.

Attached before & after screenshots of the screen in the following themes:

• Twenty Ten
• Twenty Sixteen
• Twenty Fifteen
• Twenty Fourteen
• Twenty Thirteen
• Twenty Twelve

[mercime]

Patch for heading bump only

[mercime]

In 10659:

Accessibility: Bump heading in change-cover-image.php.

See #6876.

[rogercoathup]

Guys (@boonebgorges @jjj @djpaul) this sounds like an absolute disaster -- if I'm reading this correctly, it's going to break the styling of lots of existing sites if we upgrade BuddyPress.

Our sites are styled based on the current heading items.

At the best, it's going to involve considerable re-styling of existing sites. At worst, there will be end clients / users out there who've had sites built, and are not developers who can fix the problems this is going to introduce.

Is the plan to stop people upgrading to 2.6?

If you are going to change front end elements, do it in a new set of templates, not breaking the existing ones. Just as WP does -- where they bring out a new default theme each year.

Obviously, this feedback applies to all this set of related commits, not just this one.

[mercime]

In 10737:

Revert heading bump in members/single/profile/change-cover-image.php.

Complete set of heading fixes for all templates will be addressed
in the next dev cycle.

See #6876.

[mercime]

Will be uploading new patch for this.

[mercime]

In 10963:

Accessibility: Bump heading in members change-cover-image.php.

Fixes #6876.