Skip to:

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#6822 closed defect (bug) (fixed)

Suspension of BP comment moderation functionality

Reported by: hnla Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Activity Keywords: close

Description (last modified by hnla)

Following on from two tickets #6821 & #6719 and investigation of current BP behaviour it appears we have a problematic set of functionality when checking comments for allowed number of links as configured from the WP Discussion settings.

Currently our issues are broadly:

  • Lack of a meaningful error message when exceeding permitted number of links in a comment or status update.
  • Silent destruction of entered data with no means of retrieving.
  • Inability to properly follow WP queued pending approval of comments.
  • Lack of any actual moderation - despite error message - when posting a status update; the update will be displayed despite exceeding max number of links set and generating the warning message.

Our actions result in:

  • Post a comment to a post, WP queues this for approval, approve the comment to publish it, check activity stream to find no comment added.
  • Post comment as a subscriber from the activity stream to a post, exceed the allowed links, receives the error message and no comment posted, check the WP dashboard comment is listed but listed as 'Approved', contrary to what should be seen as a comment pending. Regardless of the comment existing in WP terms and approved it will never figure in activity stream.
  • Add a status update, exceed links allowed, receive error message, however the status update is actually accepted and displayed with no actual moderation and we can see the update in user screens and members loops.

Given that bp_core_check_for_moderation isn't ready for prime time currently or at least the checks on act stream and updates are not able to tie into the WP queued pending approval the wise course of action is probably to pull this functionality altogether until #6719 can be addressed.

Edit: In addition checking the function bp_activity_check_blacklist_keys demonstrates similar behaviour in preventing the posting of the commnet to a post from the activity stream however it manages to bypass the WP check and adds the comment without allowing WP to queue it pending aproval and thus it displays in the actual post.

A patch will be added to remove:
bp_activity_check_moderation_keys() & bp_activity_check_blacklist_keys()

Change History (8)

#1 @hnla
5 years ago

  • Description modified (diff)

This ticket was mentioned in Slack in #buddypress by hnla. View the logs.

5 years ago

#3 @DJPaul
5 years ago

  • Milestone changed from 2.5 to 2.6

This ticket was mentioned in Slack in #buddypress by r-a-y. View the logs.

5 years ago

#5 @DJPaul
4 years ago

  • Milestone changed from 2.6 to Future Release

#6 @hnla
4 years ago

  • Keywords close added; needs-patch removed

the wise course of action is probably to pull this functionality altogether until #6719 can be addressed.

Given that 6719 has gone a fair way to addressing concerns lets close this ticket.

#7 @tw2113
4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Closing as per @hnla's request.

#8 @mercime
4 years ago

  • Milestone Future Release deleted
Note: See TracTickets for help on using tickets.