Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#6673 closed defect (bug) (fixed)

Wrap cover image content in a DIV

Reported by: r-a-y Owned by: r-a-y
Milestone: 2.4 Priority: normal
Severity: normal Version:
Component: Templates Keywords: has-patch
Cc:

Description

If a plugin is using the 'bp_member_before_header' hook or the 'bp_before_group_header' hook to inject some content before the header, the content is not visible in the cover image header.

Problem is we need to wrap a container around the entire cover image block instead of using the existing #item-header DIV.

Attachments (1)

6673.01.patch (8.9 KB) - added by r-a-y 6 years ago.

Download all attachments as: .zip

Change History (5)

@r-a-y
6 years ago

#1 @imath
6 years ago

Thanks a lot for this catch @r-a-y :)

I've just tested there were no impact on the javascript part when setting/deleting the cover image. And everything is ok. So for me it's good to go.

#2 @r-a-y
6 years ago

Thanks for the feedback, imath!

#3 @r-a-y
6 years ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 10290:

Cover Image: Wrap cover image block in a DIV.

Fixes a potential display issue when plugins try to use the
'bp_after_member_header' or 'bp_before_group_header' hooks to inject
content before the cover image.

Fixes #6673.

#4 @DJPaul
6 years ago

  • Component changed from Appearance to Templates
Note: See TracTickets for help on using tickets.