The component of group activity comments is "activity"

[henry.wright]

The component of group activity comments seems to be "activity". Should this be "groups" instead?

This is how it looks as things stand:

$activity = new BP_Activity_Activity( $activity_id );

// $activity_id is an activity update
echo $activity->component // activity

// $activity_id is an activity comment
echo $activity->component // activity

// $activity_id is a group activity update
echo $activity->component // groups

// $activity_id is a group activity comment
echo $activity->component // activity

[DJPaul]

I think the default route for these is through bp_legacy_theme_new_activity_comment -> bp_activity_new_comment.
Whether it should be one or another -- I think we don't win anything from changing it, and I think because we're commenting on another *activity* item, I think activity is the correct component. Bit debatable though.

[henry.wright]

Changing it will allow you to determine if the activity item is associated with the Groups component. However, the workaround is to lookup the component of the root activity item (this will either be groups or activity).

[r-a-y]

I think changing the component of a group activity comment from 'activity' to 'groups' might have some implications with the way we query activity comments. Needs research.

It's probably better to add an activity meta entry to the activity comment to identify group activity comments instead.

Regardless, any change we make here would not take effect for older group activity comments unless we wrote a tool to backfill them.

[henry.wright]

After some additional thought, I also think changing this could cause problems elsewhere (such as in cases where "activity" is expected).

[DJPaul]

This report has insufficient traction or interest in the suggestion, so I'm closing it.