Missed $args parameter in bp_core_fetch_avatar_filter()

[WeddyWood]

$args parameter is missed in bp_core_fetch_avatar_filter() function, however this parameter exist in default get_avatar() WordPress function. Thus it is impossible to use class (for example) parameter for avatar.

Default WordPress get_avatar() function accept setting this $args parameter in filter:

apply_filters( 'get_avatar', $avatar, $id_or_email, $args['size'], $args['default'], $args['alt'], $args );

Therefore now bp_core_fetch_avatar_filter() function breaks default get_avatar behaviour.

[DJPaul]

Hi WeddyWood

The $args parameter was added recently in WordPress 4.2, and it looks like no-one in BP noticed. We can add it in, sure. Thanks for pointing it out. :)

[r-a-y]

01.patch is an initial pass at supporting the new $args parameter in the 'get_avatar' filter.

Something to be wary about is the $args['extra_attr'] parameter. WP does not sanitize this whatsoever. Do we want to do anything here?

[DJPaul]

I don't think BuddyPress would have made that decision if we were implementing that, but as WordPress didn't and it is their filter, we shouldn't either.

I think your patch is fine. The only thing I suggest is to add a @since 2.4 Added $args parameter on the bp_core_fetch_avatar_filter function.

[r-a-y]

02.patch is updated to include more parameters from WordPress 4.2.0:
​https://core.trac.wordpress.org/browser/tags/4.3.1/src/wp-includes/pluggable.php#L2196

Just need a once-over before committing.

[boonebgorges]

02.patch looks good to me1

[r-a-y]

In 10287:

Avatars: Support new parameters from WordPress 4.2.0 when filtering 'get_avatar'.

WordPress 4.2.0 added a new parameter - $args - to their 'get_avatar'
filter. This $args parameter is an array that houses additional options
including the width, height and CSS class, as well as the following
parameters:

• 'extra_attr' - unsanitized HTML attributes to add to the <img> element.
• 'scheme' - URL scheme to use.
• 'rating' - Gravatar rating.
• 'force_default' - Only applicable to Gravatars. Always use the default image even if a valid Gravatar exists.

Consequently, bp_core_fetch_avatar() now supports the listed options
above as well.

Fixes #6622.