Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 4 years ago

#6607 closed enhancement (fixed)

Add "Edit" link to Toolbar for admins when viewing individual items on front

Reported by: slaFFik Owned by: boonebgorges
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: Activity Keywords: good-first-bug has-patch dev-feedback
Cc:

Description

When you open a single blog post on front you see a handy "Edit" button in Toolbar.
I believe, it will be useful to have such for activity items, forum topics etc. And links will lead to wp-admin area.

Forum topics are harder to think of all UI things, as there is already an edit link (group details etc). So I believe we can start small for activity items only.

Attachments (4)

6607.patch (2.0 KB) - added by slaFFik 5 years ago.
6607-demo.png (12.2 KB) - added by slaFFik 5 years ago.
Screenshot of how it looks on front-end
6607.2.patch (1.9 KB) - added by slaFFik 5 years ago.
6607.03.patch (1.9 KB) - added by imath 5 years ago.

Download all attachments as: .zip

Change History (17)

#1 @boonebgorges
5 years ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to Future Release

Absolutely. Good idea.

#2 @slaFFik
5 years ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to slaFFik
  • Status changed from new to assigned

@slaFFik
5 years ago

#3 @slaFFik
5 years ago

Attached is a patch, that will add Edit Activity link in Toolbar, when browsing single activity item page on front-end, aka http://trunk.bp/members/michellie/activity/669/

#4 @slaFFik
5 years ago

  • Milestone changed from Future Release to 2.4

Proposing for 2.4 release

@slaFFik
5 years ago

Screenshot of how it looks on front-end

This ticket was mentioned in Slack in #buddypress by slaffik. View the logs.


5 years ago

This ticket was mentioned in Slack in #buddypress by slaffik. View the logs.


5 years ago

#7 @slaFFik
5 years ago

About action to hook:
There is no bp_admin_bar_menu, proposed by @DJPaul. bp_adminbar_menus seems to be deprecated in 2.1 (although it's still used in bp-core-adminbar.php). The core functions also uses admin_bar_menu, so here it is.

Also cleaned up return's.

@slaFFik
5 years ago

#8 @DJPaul
5 years ago

  • Milestone changed from 2.4 to 2.5

This ticket was mentioned in Slack in #buddypress by imath. View the logs.


5 years ago

#10 @imath
5 years ago

I've refreshed the patch to latest trunk, but i must say 2 things are a bit bothering me:
1/ We are already adding a menu here to manage the member, so BuddyPress will add 2 menus into the WP Admin Bar...
2/ The Existing Edit Links are linking on front-end, this one is bringing us in back end.

@imath
5 years ago

#11 @r-a-y
5 years ago

  • Keywords dev-feedback added
  • Milestone changed from 2.5 to 2.6

Thanks for the refresh, imath.

I kind of agree with the first point. It might make sense to make this a real button beside the "Delete" and "Comment" buttons.

The second point doesn't bother me so much because those with 'bp_moderate' only have access.

Since this isn't critical and is easily implemented in a plugin, let's bump this to get more feedback.

#12 @boonebgorges
4 years ago

  • Owner changed from slaFFik to boonebgorges
  • Status changed from assigned to accepted

I like the extra button. Let's do it.

#13 @boonebgorges
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 10722:

Add an 'Edit Activity' toolbar link when viewing a single activity.

This button provides better parity with other BP content types (members,
groups).

Props slaFFik, imath.
Fixes #6607.

Note: See TracTickets for help on using tickets.