#6579 closed enhancement (fixed)
Update declarations for bp-screen-reader-text
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.4 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Templates | Keywords: | has-patch |
Cc: |
Description
... to "Utilize a more widely-adopted CSS method for hiding screen reader text, as seen in projects like jQuery UI and HTML5 Boilerplate" per WordPress Core's .screen-reader-text
Patch attached updates .bp-screen-reader-text in buddypress.css and buddypress-rtl.css
Attachments (1)
Change History (7)
#2
@
10 years ago
WordPress.org uses same declarations for .screen-reader-text https://meta.trac.wordpress.org/changeset/1794
I'm sure the WP core and meta teams would appreciate any improvements. Thanks.
#3
@
10 years ago
@mercime this is sort of half a dozen of one and six of the other.
The clip technique is recommended as the best approach currently available.
The version you show a slightly verbose example of that technique.
Do we think this is a better version?
WAI does use that slightly longer version but most other examples are the shorter 1px clip approach.
I checked what iirc twenty* themes were doing and in general with sites like AIM and WAI, hence the example I added.
Not adverse to updating our ruleset though, but ideally would like to do so as (if) it improves things.
#4
@
10 years ago
@hnla Kudos for adding the bp-screen-reader
class to buddypress.css
in the first place! If you recall, you did propose to add almost the same verbose declarations 9 months ago as recommended by WebAIM. I agree with you. The patch from WP core has been tested and updated to latest best accessibility practices, let's get this in now :)
Patch looks good to me.
Would value hnla's feedback here as well.