Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#6488 closed defect (bug) (fixed)

Incorrect variable in bp_get_the_message_star_action_link

Reported by: johnjamesjacoby Owned by:
Milestone: 2.3.2 Priority: normal
Severity: normal Version: 2.3.0
Component: Messages Keywords: commit
Cc:

Description

Looks like this could cause debug notices and malformed URLs, but I haven't tested.

$user_id vs. $r['user_id']

To test:

  • Log in as a super admin equivalent
  • View another user's Messages
  • Check for notices and malformed URL's

Since this is part of a new feature introduced in 2.3, I think we should address this in the 2.3 branch.

Attachments (1)

6488.01.patch (406 bytes) - added by johnjamesjacoby 5 years ago.

Download all attachments as: .zip

Change History (5)

#1 @r-a-y
5 years ago

  • Keywords commit added

Good catch! :)

#2 @johnjamesjacoby
5 years ago

In 9922:

Messages: Use correct variable in bp_get_the_message_star_action_link()

This fixes a potential debug notice and potential malformed URL's when a capable community administrator attempts to view another members Messages.

See #6488. (trunk)

#3 @johnjamesjacoby
5 years ago

In 9923:

Messages: Use correct variable in bp_get_the_message_star_action_link()

This fixes a potential debug notice and potential malformed URL's when a capable community administrator attempts to view another members Messages.

See #6488. (2.3 branch, for 2.3.2)

#4 @johnjamesjacoby
5 years ago

  • Keywords 2nd-opinion removed
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.