Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#6458 closed defect (bug) (fixed)

Messages unread count loses count/no-count class

Reported by: johnjamesjacoby Owned by: djpaul
Milestone: 2.4 Priority: normal
Severity: normal Version:
Component: Messages Keywords: has-patch early reporter-feedback
Cc:

Description

To duplicate:

  • Receive a private message from another user
  • See the displayed user navigation shows a bubble with "1" and a span with the class count
  • Visit your private message inbox and view the conversation thread
  • Notice that the "1" is now "0" but also that the span does not have the no-count class

This only happens when viewing a single conversation thread.

Attachments (1)

6458.01.patch (778 bytes) - added by johnjamesjacoby 5 years ago.

Download all attachments as: .zip

Change History (5)

#1 @johnjamesjacoby
5 years ago

  • Keywords has-patch early added

6458.01.patch modifies messages_screen_conversation() and ports count calculation logic from BP_Messages_Component::setup_nav().

#2 @DJPaul
5 years ago

  • Keywords reporter-feedback added

Tired eyes here, but I can't see what this does other than add a class to the markup? Is this just the fix required? If so, go for it.

Last edited 5 years ago by DJPaul (previous) (diff)

#3 @DJPaul
5 years ago

ah, I see the code came from the setup_nav function in the loader.

#4 @djpaul
5 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 10231:

Messages: single conversation thread missing count class

Fixes #6458

Props johnjamesjacoby

Note: See TracTickets for help on using tickets.