Use "Mystery Group" avatar when group avatar not available.

[sooskriszta]

At the moment, if a group avatar has not been uploaded then BuddyPress shows the "mystery man" avatar instead (just as it does for user profile photos)

Instead, we should use a "mystery group" avatar, to distinguish between groups and users. Something like this (but obviously, more in tune with the mystery man style)

[sooskriszta]

Mystery man

[sooskriszta]

Mystery group

[hnla]

Like the notion!

[DJPaul]

Ooh, interesting.

cc @imath

[imath]

Thanks for the ping DJPaul, this is interesting! We could actually use the BuddyPress logo :)

[sooskriszta]

Replying to imath:

We could actually use the BuddyPress logo

Great idea

[DJPaul]

"Mystery Person", please. :) Let's

[netweb]

r1004 missed a ticket reference, here it is:

Changeset r10041
Mystery person, not mystery man.
More to do here, but it's a start.

[sooskriszta]

Replying to DJPaul:

"Mystery Person", please.

Mystery Man ​https://codex.wordpress.org/Function_Reference/get_avatar ;-)

[abweb]

Archive contains patch file and new image for groups avatar

[boonebgorges]

Image looks great.

6372.diff​ makes the following improvements:

• I changed the implementation a little bit so that the default kicks in before the 'bp_core_default_avatar_group' filter. This ensures that existing filters here will continue to work as expected.
• Added a 50x50 image, and support for loading the thumbnail version when necessary.

Question for the team: Why do we ever ping Gravatar for group images? They will never match. I guess if you're getting a Wavatar or some other generated image, maybe you want the variety? In 6372.diff​ I completely disabled Gravatar for group images, but maybe this is too extreme. Maybe we should only disable if avatar_default is set to mm? (See #4571 and [7769].)

[DJPaul]

@boonebgorges I think that was done because we thought it might be useful to site owners who register matching email addresses with Gravatar. It sounds pretty ridiculous now. I don't think we ever gave the impact of additional requests any consideration at the time.

[boonebgorges]

Thanks, @DJPaul. I am going to go ahead and disable Gravatar requests for groups across the board. This is going to result in a change in behavior for people who are expecting Wavatar etc for their groups, but the value can be filtered for anyone who cares. Let's see if we annoy anyone :)

[boonebgorges]

In 10721:

Introduce 'mystery group' avatar for groups without custom avatar.

This nifty new image is totally grouperiffic, and it's gonna supercharge
your BuddyPress community, to the extreme.

As part of the improvement, Gravatar requests for group avatars have been
disabled by default. Gravatar requests never match for groups, anyway, so
this should save HTTP requests in most cases. Filter 'bp_core_fetch_avatar_no_grav'
to restore the previous behavior.

Props sooskriszta, abweb.
Fixes #6372.