Skip to:
Content

Opened 2 years ago

Closed 16 months ago

#6372 closed enhancement (fixed)

Use "Mystery Group" avatar when group avatar not available.

Reported by: sooskriszta Owned by: boonebgorges
Milestone: 2.6 Priority: normal
Severity: normal Version:
Component: Groups Keywords: has-patch commit
Cc: vivek@…

Description

At the moment, if a group avatar has not been uploaded then BuddyPress shows the "mystery man" avatar instead (just as it does for user profile photos)

Instead, we should use a "mystery group" avatar, to distinguish between groups and users. Something like this (but obviously, more in tune with the mystery man style)

Attachments (4)

3196412953-074af62ea5ff218b6a6eeab89104f616.png (3.2 KB) - added by sooskriszta 2 years ago.
Mystery man
group.svg (1.1 KB) - added by sooskriszta 2 years ago.
Mystery group
groups-default-avatar#10.zip (8.7 KB) - added by abweb 17 months ago.
Archive contains patch file and new image for groups avatar
6372.diff (6.8 KB) - added by boonebgorges 17 months ago.

Download all attachments as: .zip

Change History (18)

@sooskriszta
2 years ago

Mystery group

#1 @sooskriszta
2 years ago

  • Cc vivek@… added

#2 @hnla
2 years ago

Like the notion!

#3 @DJPaul
2 years ago

  • Keywords has-patch early added
  • Milestone changed from Awaiting Review to Future Release

Ooh, interesting.

cc @imath

#4 follow-up: @imath
2 years ago

Thanks for the ping DJPaul, this is interesting! We could actually use the BuddyPress logo :)

#5 in reply to: ↑ 4 @sooskriszta
2 years ago

Replying to imath:

We could actually use the BuddyPress logo

Great idea

#6 @sooskriszta
2 years ago

  • Summary changed from User "Mystery Group" avatar when group avatar not available. to Use "Mystery Group" avatar when group avatar not available.

#7 follow-up: @DJPaul
2 years ago

  • Keywords needs-patch added; has-patch early removed

"Mystery Person", please. :) Let's

#8 @netweb
2 years ago

r1004 missed a ticket reference, here it is:

Changeset r10041
Mystery person, not mystery man.
More to do here, but it's a start.

#9 in reply to: ↑ 7 @sooskriszta
2 years ago

Replying to DJPaul:

"Mystery Person", please.

Mystery Man https://codex.wordpress.org/Function_Reference/get_avatar ;-)

@abweb
17 months ago

Archive contains patch file and new image for groups avatar

@boonebgorges
17 months ago

#10 @boonebgorges
17 months ago

  • Keywords has-patch 2nd-opinion added; needs-patch removed
  • Milestone changed from Future Release to 2.6
  • Type changed from defect (bug) to enhancement

Image looks great.

6372.diff makes the following improvements:

  • I changed the implementation a little bit so that the default kicks in before the 'bp_core_default_avatar_group' filter. This ensures that existing filters here will continue to work as expected.
  • Added a 50x50 image, and support for loading the thumbnail version when necessary.

Question for the team: Why do we ever ping Gravatar for group images? They will never match. I guess if you're getting a Wavatar or some other generated image, maybe you want the variety? In 6372.diff I completely disabled Gravatar for group images, but maybe this is too extreme. Maybe we should only disable if avatar_default is set to mm? (See #4571 and [7769].)

This ticket was mentioned in Slack in #buddypress by dcavins. View the logs.


16 months ago

#12 @DJPaul
16 months ago

  • Keywords commit added

@boonebgorges I think that was done because we thought it might be useful to site owners who register matching email addresses with Gravatar. It sounds pretty ridiculous now. I don't think we ever gave the impact of additional requests any consideration at the time.

#13 @boonebgorges
16 months ago

  • Keywords 2nd-opinion removed

Thanks, @DJPaul. I am going to go ahead and disable Gravatar requests for groups across the board. This is going to result in a change in behavior for people who are expecting Wavatar etc for their groups, but the value can be filtered for anyone who cares. Let's see if we annoy anyone :)

#14 @boonebgorges
16 months ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 10721:

Introduce 'mystery group' avatar for groups without custom avatar.

This nifty new image is totally grouperiffic, and it's gonna supercharge
your BuddyPress community, to the extreme.

As part of the improvement, Gravatar requests for group avatars have been
disabled by default. Gravatar requests never match for groups, anyway, so
this should save HTTP requests in most cases. Filter 'bp_core_fetch_avatar_no_grav'
to restore the previous behavior.

Props sooskriszta, abweb.
Fixes #6372.

Note: See TracTickets for help on using tickets.