BuddyPress navigation appends a trailing slash to the link in a subnav item when link is forced

[pareshradadiya]

As described in summary link has a trailing slash ​http://example.com/foo/bar/blah/?action=edit&id=30/. So when i do

$_REQUEST['id']

it give me 30/. Url should be like this ​http://example.com/foo/bar/blah/?action=edit&id=30

[pareshradadiya]

Path and php unit testcases

[boonebgorges]

Thanks for the report and for the patch. I think this is a good call - when plugin registers its own link, we should leave it up to the plugin author to ensure that it's trailingslashed. (Side note: this is a good reminder that trailingslashit() is not a very sophisticated function. A "trailingslashit-for-URLs" would be properly sensitive to query params.)

[boonebgorges]

In 9700:

Add some tests for trailingslashit() behavior in bp_core_new_subnav_item().

See #6353.

[boonebgorges]

In 9701:

Don't trailingslash the href of subnav items if the 'link' was provided explicitly in bp_core_new_subnav_item().

trailingslashit() is not smart enough to detect links with query params, so
that links can be improperly trailingslashed in some cases. More generally,
it's not the case that all links should be trailingslashed (in particular,
those that do not lead to WP/BP pages), so plugin authors should be responsible
for trailingslashing on their own.

Props pareshradadiya.
See #6353.

[boonebgorges]

Also, thanks for the security enhancement of esc_url_raw(), though in this case I believe we should be using esc_url(), because we want to encode URL entities.

[boonebgorges]

In 9702:

Improved attribute escaping when outputting subnav link items.

Props pareshradadiya.
Fixes #6353.

[pareshradadiya]

Yep. I agree with esc_url(). thanks for your correction.