Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#6329 closed defect (bug) (fixed)

Notifications not clearing for deleted messages if they have not been read first.

Reported by: mcpeanut Owned by: boonebgorges
Milestone: 2.3 Priority: high
Severity: major Version: 2.2.1
Component: Toolbar & Notifications Keywords: has-patch
Cc:

Description

This is also confirmed by Henrywright and danbp

Attachments (1)

6329.diff (969 bytes) - added by pareshradadiya 5 years ago.
messages_thread_deleted_thread hook added to force delete corresponding notifications when message is deleted and some recipients remain for message

Download all attachments as: .zip

Change History (6)

#2 @DJPaul
5 years ago

  • Milestone changed from Awaiting Review to 2.3

Oh, sadness. :(

Good catch, and thanks for bringing it here from the forum.

@pareshradadiya
5 years ago

messages_thread_deleted_thread hook added to force delete corresponding notifications when message is deleted and some recipients remain for message

#3 @pareshradadiya
5 years ago

  • Keywords has-patch added; needs-patch removed

#4 @boonebgorges
5 years ago

Thanks for the patch, pareshradadiya. I think we can do this without repurposing the hook name, though.

#5 @boonebgorges
5 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 9744:

Ensure that corresponding notifications are deleted when a message thread is deleted.

This means deleting the notifications for each message in the thread, for each
recipient on the thread. Previously, only a subset of these were being deleted.

This changeset removes a test that used a dummy thread_id, a testing
technique that doesn't work with the new looping technique used for
notification deletion. The new unit test is a proper replacement.

Props pareshradadiya for an initial patch.
Fixes #6329.

Note: See TracTickets for help on using tickets.