Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#6266 closed enhancement (fixed)

Update grunt-contrib-jshint to 0.11.0

Reported by: netweb Owned by: djpaul
Milestone: 2.3 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Cc:

Description

Update grunt-contrib-jshint to v0.11.0

https://github.com/gruntjs/grunt-contrib-jshint/compare/v0.10.0...v0.11.0

Patch includes exclusion for external library src/bp-core/js/jquery-scroll-to.js in .jshintignore otherwise various JSHint errors occur due to the updated usage of JSHint v2.6.


I went looking to replace the BP customised version of src/bp-core/js/jquery-scroll-to.js with the original v1.4.12 source but things appear to not be all ok in that realm, attached is 6266-jquery-scroll-to.diff of the original source if you wanted to go down that route:

Attachments (2)

6266.diff (784 bytes) - added by netweb 5 years ago.
6266-jquery-scroll-to.diff (8.5 KB) - added by netweb 5 years ago.

Download all attachments as: .zip

Change History (6)

@netweb
5 years ago

#1 @djpaul
5 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 9566:

Tools: update grunt-contrib-jshint to latest version, and add an existing third party script to JSHint ignore list.

With the new version of JSHint, jquery-scroll-to.js reports errors relating to unused functions.
For now, add this legacy script to the ignore list so that the Grunt build tasks pass.

Fixes #6266, props netweb

#2 @DJPaul
5 years ago

I can't remember what we've done to poor jquery.scrollTo.js without looking, but it sounds like our version is modified and out of step. It would be nice to update it, but I think we should open a separate ticket and investigate doing that.

#3 @DJPaul
5 years ago

  • Milestone changed from Awaiting Review to 2.3

#4 @DJPaul
3 years ago

  • Component changed from Tools - Build Process to Build/Test Tools
Note: See TracTickets for help on using tickets.