buddypress.js has dependency to deprecated bp-jquery-scroll-to.js

[wpdennis]

​bp-jquery-scroll-to.js was deprecated in 2.1 but is still a dependency by default in ​bp_core_get_js_dependencies():

function bp_core_get_js_dependencies() {
    return apply_filters( 'bp_core_get_js_dependencies', array(
	'jquery',
	'bp-confirm',
	'bp-widget-members',
	'bp-jquery-query',
	'bp-jquery-cookie',
	'bp-jquery-scroll-to'
    ) );
}

With define('BP_IGNORE_DEPRECATED', true); the buddypress.js isn't loaded anymore.

[wpdennis]

And the file buddypress.js itself is still using jq.scrollTo(), e.g. for comments to activities.

Depending on the reasons why bp-jquery-scroll-to was deprecated in first place, I think this should be reverted or buddypress.js should at least check if the function exists. But even then scrollTo would be more optional than deprecated.

[boonebgorges]

I think you're correct that this never should have been deprecated in the first place. [8559]

[boonebgorges]

In 9477:

Undeprecate jquery.scroll-to.js.

This file was deprecated as part of [8559], which did some miscellaneous
cleanup of old scripts. However, scrollTo() continues to be used in bp-legacy
JS, and so jquery.scroll-to remains a requirement. It should not be broken by
BP_IGNORE_DEPRECATED.

Props wpdennis.
Fixes #6216.