Opened 10 years ago
Closed 10 years ago
#6216 closed defect (bug) (fixed)
buddypress.js has dependency to deprecated bp-jquery-scroll-to.js
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.3 | Priority: | normal |
Severity: | normal | Version: | 2.1 |
Component: | Core | Keywords: | dev-feedback |
Cc: | mail@… |
Description
bp-jquery-scroll-to.js was deprecated in 2.1 but is still a dependency by default in bp_core_get_js_dependencies():
function bp_core_get_js_dependencies() { return apply_filters( 'bp_core_get_js_dependencies', array( 'jquery', 'bp-confirm', 'bp-widget-members', 'bp-jquery-query', 'bp-jquery-cookie', 'bp-jquery-scroll-to' ) ); }
With define('BP_IGNORE_DEPRECATED', true); the buddypress.js isn't loaded anymore.
Change History (3)
Note: See
TracTickets for help on using
tickets.
And the file buddypress.js itself is still using jq.scrollTo(), e.g. for comments to activities.
Depending on the reasons why bp-jquery-scroll-to was deprecated in first place, I think this should be reverted or buddypress.js should at least check if the function exists. But even then scrollTo would be more optional than deprecated.