Don't show "Favorites" menu point if favorites are disabled

[wpdennis]

If I disable favorites like this:

add_filter('bp_activity_can_favorite', function() {
    return false;
});

the favorites menu point under activities is still available. I think it should be removed implicitly, even if there are favorites "from the past". The user experience should be consistent and if I can't favorise something, I shouldn't have a menu point for it.

If someone googles for this and needs a quick solution, this hook removes the menu point:

add_action('bp_activity_setup_nav', function() {
    $bp = buddypress();
    if (isset($bp->bp_options_nav['activity']) and isset($bp->bp_options_nav['activity']['favorites']))
        unset($bp->bp_options_nav['activity']['favorites']);
});

[netweb]

Related: ​#bbPress2594 BuddyPress favorites and/or subscription menus still visible when components are disabled

[imath]

Thanks for your feedback wpdennis, i agree we should not display the "favorites" navigation elements if the feature is disabled.

I suggest 6214.patch

[imath]

In 9539:

Only show "Favorites" nav items when favoriting activities is enabled

props wpdennis

Fixes #6214