Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 11 years ago

Last modified 10 years ago

#6200 closed defect (bug) (fixed)

BP legacy template RTL style not loading.

Reported by: geminorum Owned by: DJPaul
Priority: high Milestone: 2.3
Component: I18N Version: 1.9
Severity: normal Keywords:
Cc:

Description

All I see the bp-legacy-css-rtl handle load the previously loaded buddypress.css again.

Seems the BP_Legacy::enqueue_styles() must pass full url location of the buddrpress-rtl.css to wp_style_add_data()

And since the RTL style, unlike default theme behavior, is a duplicate of the main style, I think:

$stylesheet = is_rtl() ? "buddypress-rtl{$min}.css" : "buddypress{$min}.css";
$asset = $this->locate_asset_in_stack( $stylesheet, 'css' );

Change History (4)

#1 @DJPaul
12 years ago

  • Milestone Awaiting Review2.3
  • Version 2.21.9

Need to double-check this but urgh. :(

#2 @DJPaul
11 years ago

  • Owner set to DJPaul
  • Status newassigned

Confirmed, fixing.

#3 @djpaul
11 years ago

  • Resolutionfixed
  • Status assignedclosed

In 9629:

BP-Legacy: when loading RTL CSS, don't also load the LTR CSS.

Unlike WordPress, our RTL is a clone of the LTR file, instead of containing just the RTL adjustments.

wp_enqueue_style's RTL support works the WordPress way, not the BuddyPress way, so some of the logic has needed to be duplicated.
We maintain backwards compatibility with the style's existing script names in case existing sites have explicitly de-registered these styles already.

Fixes #6200

#4 @DJPaul
10 years ago

  • Component Locale - RTLI18N
Note: See TracTickets for help on using tickets.