Skip to:

Opened 9 years ago

Closed 9 years ago

#6163 closed defect (bug) (fixed)

bp_settings_pending_email_notice() message using wrong email

Reported by: willgladstone's profile willgladstone Owned by:
Milestone: 2.4 Priority: normal
Severity: normal Version:
Component: Settings Keywords: has-patch needs-testing

Description (last modified by DJPaul)

bp_settings_pending_email_notice() spits out a message to check your email for verification of a change in email address. The email it tells you to check is your old email but it sends the verification to the new email. The message should be corrected to tell you to check your new email.

printf( ( 'There is a pending change of your email address to <code>%1$s</code>.<br />Check your email (<code>%2$s</code>) for the verification link. <a href="%3$s">Cancel</a>', 'buddypress' ), $pending_emailnewemail?, bp_get_displayed_user_email(), esc_url( bp_displayed_user_domain() . bp_get_settings_slug() . '/?dismiss_email_change=1' ) )

should instead be:

printf( ( 'There is a pending change of your email address to <code>%1$s</code>.<br />Check your email (<code>%2$s</code>) for the verification link. <a href="%3$s">Cancel</a>', 'buddypress' ), $pending_emailnewemail?, $pending_emailnewemail?, esc_url( bp_displayed_user_domain() . bp_get_settings_slug() . '/?dismiss_email_change=1' ) )

Attachments (1)

6163.01.patch (11.7 KB) - added by johnjamesjacoby 9 years ago.

Download all attachments as: .zip

Change History (9)

#1 @DJPaul
9 years ago

  • Milestone changed from Awaiting Review to 2.3

Nice spot

#2 @DJPaul
9 years ago

  • Version 2.1 deleted

#3 @johnjamesjacoby
9 years ago

  • Component changed from Core to Settings
  • Keywords has-patch needs-testing added

6163.01.patch does the following:

  • Separates verification email sending procedure into its own function.
  • Introduces the ability to resend a verification email.
  • Updates the surrounding verbiage to be simpler and more accurate.
  • Adds filters to bp_get_settings_pending_email_notice() to allow text and links to be modified.
  • Uses more helper, functions like trailingslashit, add_query_arg(), etc...

#4 @DJPaul
9 years ago

Let's -- initially -- just change the email address, fixing this bug, and then refresh/move @johnjamesjacoby's patch to a new ticket to cover the refactoring improvements and other tidy-up.

#5 @DJPaul
9 years ago

  • Milestone changed from 2.3 to 2.4

#6 @DJPaul
9 years ago

  • Description modified (diff)

#7 @djpaul
9 years ago

In 10236:

Settings: fix notification when a change of email address is pending

The verification email is sent to the new address, not the previous
address. The message was misleading.

See #6163

Props willgladstone

#8 @DJPaul
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

The email address in the message has been fixed in the above commit, and I've moved John's patch and comments into #6654 to deal with separately.

Note: See TracTickets for help on using tickets.