Notice: wpdb::escape is deprecated since version 3.6! Use wpdb::prepare() or esc_sql() instead.

[spenser4551]

File: wp-content/plugins/buddypress/bp-forums/bp-forums-bbpress-sa.php

                 /**
		 * Stub for escape_deep() compatibility.
		 *
		 * @see WPDB::escape_deep() for description of parameters and
		 *      return values.
		 *
		 * @param mixed $data See {@link WPDB::escape_deep()}.
		 * @return mixed $data See {@link WPDB::escape_deep()}.
		 */
		function escape_deep( $data ) {
			return $this->escape( $data );
		}

[spenser4551]

Change to:

function escape_deep( $data ) {
    return esc_sql( $data );
}

[johnjamesjacoby]

Can you confirm that the retired forums still function with this change? I recall esc_sql() not being functionally equivalent to WPDB::escape_deep().

This is going to be a low priority fix for us, but I'd like to get it resolved in 2.3 so it's safe.

[thebrandonallen]

Just to throw this out there. This is one of many deprecation and PHP notices that show up with the legacy forums component. A good number of them are related to the bbPress 1.x branch. I say we either fix them all (which I'll be happy to work on), or leave them as-is. Unless, of course, they're bringing upon the wrath of the white screen.

Can you confirm that the retired forums still function with this change? I recall esc_sql() not being functionally equivalent to WPDB::escape_deep().

They are functionally equivalent, but I haven't tested yet to be sure.

[spenser4551]

Same functionally equivalent, I have changed it on my dev server and so far no errors, but I am fairly new to Buddypress so not sure if I am hitting of its use cases. Also it's not causing a white screen, however on the development and production server we make sure there are no errors happening, even notices due to our SLA and for debugging/ error capturing. Since if there is an error log we know it's actually a problem and not juse notices.

[DJPaul]

Our bbdb class extends wpdb, and we implement wpdb->escape_deep -- which calls wpdb->escape -> _weak_escape -> addslashes -- because old bbPress' original bbdb class had the method.

wpdb->escape's documentation says to use either wpdb->prepare or esc_sql. I agree that esc_sql is appropriate here.

[DJPaul]

[]

[djpaul]

In 10957:

Forums: fix use of deprecated SQL escaping function in legacy forums integration code.

Fixes #6157

Props spenser4551