bp_core_get_active_member_count() multisite query does not exclude 'spam' status

[johnjamesjacoby]

If multisite, it's possible for spam users to be included in the active member count query.

The query was introduced in r5987:

"SELECT ID FROM {$wpdb->users} WHERE (user_status != 0 OR deleted != 0 OR user_status != 0)"

It should likely be:

"SELECT ID FROM {$wpdb->users} WHERE (user_status != 0 OR deleted != 0 OR spam != 0)"

[imath]

Just wrote a unit test to check. Actually the count is ok because of this part of the query user_status != 0. In multisite, as we also add a value in the user_status field of the users table, there's no problem.

But we should fix it :)

[johnjamesjacoby]

What happens if users are marked as spam in WordPress multisite but not via BuddyPress? Does the user_status change to 1 also?

[imath]

Unit tests for bp_core_get_active_member_count()

[imath]

Replying to johnjamesjacoby:

What happens if users are marked as spam in WordPress multisite but not via BuddyPress? Does the user_status change to 1 also?

In multisite, BuddyPress is adding a row action "Spam/Unspam" that uses bp_core_process_spammer_status().
In network Administration, WordPress is adding 2 bulk actions "Spam/Unspam" that uses update_user_status(). We're hooking it using ''make_spam_user' and ''make_ham_user' so that it passes in bp_core_process_spammer_status().

6155.02.unittests.patch is 6155.unittests.patch + a unit tests for multite bulk spam action.

Trac ticket: ​https://buddypress.trac.wordpress.org/ticket/6155

[espellcaste]

In 13981:

Unit tests: Add test that confirms the multisite query for bp_core_get_active_member_count() excludes the spam status.

Props imath, johnjamesjacoby.

Closes ​https://github.com/buddypress/buddypress/pull/328
Fixes #6155