Skip to:
Content

Opened 3 years ago

Closed 3 years ago

#6150 closed enhancement (fixed)

Filter numeric constants

Reported by: slaFFik Owned by: boonebgorges
Milestone: 2.3 Priority: normal
Severity: normal Version:
Component: Core Keywords: good-first-bug has-patch needs-refresh
Cc:

Description

I believe this number:

if ( 5 <= bp_get_thread_recipients_count() ) {

should be a filterable value.

In bp_get_the_thread_recipients().

Also might be a good idea to search other such constants.

Attachments (1)

i6150.diff (988 bytes) - added by henry.wright 3 years ago.

Download all attachments as: .zip

Change History (8)

#1 @boonebgorges
3 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Type changed from defect (bug) to enhancement

#2 @DJPaul
3 years ago

  • Keywords good-first-bug added

#3 @henry.wright
3 years ago

The docs say the bp_get_the_thread_recipients() function is no longer used by BuddyPress since 2.2.0. Will a patch still be needed?

@henry.wright
3 years ago

#4 @henry.wright
3 years ago

  • Keywords has-patch added; needs-patch removed

Grateful if you could let me know if the .diff is OK. I generated it via Git from these instructions as opposed to the usual way via SVN.

#5 @DJPaul
3 years ago

  • Milestone changed from Future Release to 2.3

#6 @imath
3 years ago

  • Keywords needs-refresh added

Since 2.2, this check was moved directly into the template, so i think we need to be consistent and work on a new patch so that templates < 2.2 and tempates >= 2.2 can filter this value.

#7 @boonebgorges
3 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 9830:

Introduce bp_get_max_thread_recipients_to_list().

This wrapper function makes it possible to filter the number of recipients on
a message thread beyond which the 'Conversation between...' gloss goes from
listing the recipients' names to simply saying "x recipients".

Props henry.wright.
Fixes #6150.

Note: See TracTickets for help on using tickets.