bp-messages.php error in messages_install()

[DJPaul]

Not sure how important this is, but it does cause an error in the web server log.

SITUATION: WPMU 2.7, BP from Trunk, Clean install.
NOTE: BP files already put in place before running WPMU install.

1) WPMU installs with some WPMU errors in the log. Not BP's problem. Anyhow.
2) On the WPMU "successful install here, remember to chmod your folders back to 755, here's your admin password, click here to log in page", no errors are generated. So far so good.
3) Then you follow the link to take you to ​http://example.com/wp-login.php. Again, no errors. You log in...
4) It takes you to ​http://example.com/wp-admin/ and we have errors! Here's the last bug I've found with this bit:

'wordpress.wp_bp_messages_threads' doesn't exist for query ALTER TABLE wp_bp_messages_threads DROP INDEX sender_ids  made by require_once, require, do_action, call_user_func_array, messages_check_installed, messages_install, referer: http://example.com/wp-login.php

Problem: messages_install(). The ALTER TABLE is where the error is. Obviously, if this is an upgrade, then the ALTER TABLE should be executed. However, if it's a first install, then there's no existing table to alter, so it errors.
I don't know how best to catch this one, so I leave the patch to someone else.

[apeatling]

(In [1258]) Fixes #614

[(none)]

Milestone Private Messaging 1.0 deleted