Skip to:

Opened 9 years ago

Closed 9 years ago

#6108 closed defect (bug) (wontfix) - 5 of the 7 navigation links are highlighted in all Member Profile pages

Reported by: mercime's profile mercime Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Sites Keywords: close
Cc: r-a-y


Screenshot attached.

Attachments (1)

screenshot-buddypress org 2015-01-11 06-49-54.png (228.1 KB) - added by mercime 9 years ago.

Download all attachments as: .zip

Change History (8)

#1 @DJPaul
9 years ago

  • Cc r-a-y added
  • Milestone changed from Awaiting Review to

r-a-y did we have a patch that I think you committed recently that addressed menu highlight classes? If so, I believe the next beta/RC should fix this on

#2 @r-a-y
9 years ago

As of BP 2.2, all BP pages are set to the page ID of zero.

Using is_page( 'ANYSLUG' ) on a single BP page with theme compatibility enabled will always return true.

This is due to a WP core bug with the is_page() function when a page ID is zero - #WP24674.

I've added a patch to the WP ticket for those that are interested:

The header for uses a ton of is_page( 'PAGE_SLUG' ):

This is causing the multitude of tabs being highlighted on member profile pages.

In the meantime, switching to using a WP nav menu might fix this issue.

This bug was also mentioned on the forums:

Last edited 9 years ago by r-a-y (previous) (diff)

#3 @boonebgorges
9 years ago

Thanks for looking into this more, r-a-y. I've left a comment and a new patch on the WP ticket. Could you weigh in?

#4 @r-a-y
9 years ago

The (string) casting sounds like a great idea!

#5 @hnla
9 years ago

I don't get the impression that there's a rush to push for a solution on that WP ticket, this has reared it's ugly head for me so any legitimate check a site does using is_page() has to be accompanied by a !bp_is_user() :)

#6 @boonebgorges
9 years ago

  • Keywords close added In your face, hnla ;)

May I suggest a wontfix here? I don't think it's worth doing any additional juggling in BP if this will be fixed in WP 4.2+.

#7 @mercime
9 years ago

  • Milestone deleted
  • Resolution set to wontfix
  • Status changed from new to closed

@boonebgorges 10-4 resolving as wontfix per your suggestion :)

Note: See TracTickets for help on using tickets.