Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 4 years ago

#6010 closed enhancement (fixed)

Screen reader class - audit of existing selectors and their labels

Reported by: hnla Owned by: boonebgorges
Milestone: 2.2 Priority: normal
Severity: minor Version:
Component: Templates Keywords: has-patch
Cc:

Description

Ticket covers the task of auditing all existing BP screens where we might be using and hiding form labels to add new bp-screen-reader-text class, and removing display: none rulesets where they may exist. (as suggested in #5513)

Attachments (1)

6010.patch (1.3 KB) - added by hnla 6 years ago.
Update messages search for label text and screen reader class.

Download all attachments as: .zip

Change History (6)

#1 @DJPaul
6 years ago

  • Milestone changed from Awaiting Review to Future Release

#2 @hnla
6 years ago

  • Milestone changed from Future Release to 2.2

Styles audited and all instances of label/inputs checked visually for any previous hidden label text, none exist other than out recent additions and screen reader class for messages/notifications.

messages search input though is wrapped in a label without any text, this should be updated to include text and have class added for screen reader text to hide visually and preserve existing installations expectation with element.

@hnla
6 years ago

Update messages search for label text and screen reader class.

#3 @hnla
6 years ago

  • Keywords has-patch added

#4 @boonebgorges
6 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 9240:

Improve <label> markup for mesage search form.

  • Associate the label properly with the labeled element.
  • Add bp-screen-reader-text class for better consistency with other similar text in BP templates.

Props hnla.
Fixes #6010.

#5 @DJPaul
4 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.