Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

#6003 closed defect (bug) (fixed)

variable firstrow is used in multiple methods that can be called simultaiously

Reported by: andemann Owned by: boonebgorges
Milestone: 2.2 Priority: normal
Severity: normal Version: 2.1
Component: Appearance - Template Pack Keywords:
Cc:

Description

In buddypress/bp-templates/bp-legacy/jsbuddypress.js the variable firstrow is used both in
jq( document ).on( 'heartbeat-send.buddypress', on line 1605 to hold the timestamp for last updated

and in jq('#aw-whats-new-submit').on( 'click', function() { on line 101
it is used to hold a reference towards the first li in the activity list.

This causes and error if the wordpress heartbeat is triggered while a new activity is posted.

Change History (2)

#1 @boonebgorges
5 years ago

  • Component changed from Core to Template Pack
  • Milestone changed from Awaiting Review to 2.2
  • Owner set to boonebgorges
  • Status changed from new to accepted

Nice find. Thanks for the report.

#2 @boonebgorges
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 9129:

Use a unique variable name in activate heartbeat JS.

The name 'firstrow' was colliding with the "What's new" JS.

Props andemann.
Fixes #6003.

Note: See TracTickets for help on using tickets.