Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#6000 closed defect (bug) (fixed)

No template notices are displayed in twentyfifteen

Reported by: imath Owned by: imath
Milestone: 2.2 Priority: normal
Severity: normal Version:
Component: Appearance - Template Pack Keywords: has-patch commit
Cc:

Description

i think it's due to this part of the theme's css :

.updated:not(.published) {
     display: none;
}

It would be nice if a theme expert could suggest a patch.

Attachments (1)

6000-1.patch (401 bytes) - added by hnla 6 years ago.
Add display: block to messages.updated to counter twentyfifteen .updated:not(.published) ruleset

Download all attachments as: .zip

Change History (8)

#1 @hnla
6 years ago

I'll try and take a look - looks possibly an awkward one to work around from our point of view.

#2 @hnla
6 years ago

Think actually this is a relatively trivial fix.

We already namespace our messages elements as we do most of our selectors so the existing ruleset:

#buddypress div#message.updated

A block level div simply needs to have it's default nature re-declared.

So adding display: block given we already have a high degree/weight of specificity for this ruleset will, and does in testing, re-enable the rendering of our template notice.

Display: block is a non problematic property to add, it's the default property for the element and we are not changing it anywhere to be inline.

If circumstances were to change having this declaration of block level would not be a problem.

I can patch and add this when we're clear of some other changes being run through in bp css.

#3 @imath
6 years ago

Thanks for your expertise hnla :) Your patch will be very welcome.

@hnla
6 years ago

Add display: block to messages.updated to counter twentyfifteen .updated:not(.published) ruleset

#4 @hnla
6 years ago

  • Keywords has-patch added; needs-patch removed

#5 @DJPaul
6 years ago

  • Keywords commit added

Thanks for the patch, hnla

#6 @imath
6 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 9159:

Make sure template notices are displayed in twentyfifteen theme

props hnla

Fixes #6000

#7 @johnjamesjacoby
6 years ago

  • Component changed from Component - Any/All to Appearance - Template Pack
Note: See TracTickets for help on using tickets.