Registration screen doesn't use BP_REGISTER_SLUG

[slaFFik]

Test flow:

• remove connection on BuddyPress - Pages page between Registration page and any WP page
• define BP_REGISTER_SLUG with as sample-page (for example, first default page after clean WP instal)
• open site.com/sample-page

I expect there to be registration page content, but I see ordinary WP page content so far

Filtering bp_get_signup_slug() gives no result as well.

[DJPaul]

Similar to your report in #5991, this is likely a routing bug somewhere. For legacy reasons, if this slug is set, it should override whatever it is set to in the Page Mapping.

[r-a-y]

I would say this is the lowest of all priorities.

Part of the problem was moving to WordPress pages in BP 1.5. Need to use sample-page as the registration page? Set it in the BP admin area.

The only way I see this being useful is if you are trying to automate the BP setup process for a new site.

We should probably deprecate the usage of the BP_REGISTER_SLUG constant if we haven't already. Or add some notes about this to a relevant codex page if applicable.

[boonebgorges]

Yeah, I agree with @r-a-y that there's probably no way for BP_REGISTER_SLUG to work since 1.5. (The case is different for BP_MEMBERS_SLUG etc, since in the case of component directories, the post_name determines the "root slug".) I suggest we add documentation to this effect.

[imath]

Slug constants were deprecated in 12.0.0