Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 6 years ago

#5963 closed defect (bug) (fixed)

buddypress.min.js missing in legacy lookup at locate_asset_in_stack

Reported by: nofearinc Owned by: boonebgorges
Milestone: 2.2 Priority: normal
Severity: normal Version:
Component: Appearance - Template Pack Keywords: has-patch
Cc:

Description

Installing latest BuddyPress from trunk with the twentyfourteen theme tries to load buddypress.min.js at locate_asset_in_stack. Since I don't use a BuddyPress compatible theme, it's trying to load the minified script from bp-legacy while only the full script is available there.

This leads to notices in the enqueue_scripts function when $assetlocation? and $assethandle? are expected for the file load.

The patch is stripping the '.min' part when searching in bp-legacy.

Attachments (1)

5963.patch (536 bytes) - added by nofearinc 6 years ago.

Download all attachments as: .zip

Change History (3)

@nofearinc
6 years ago

#1 @boonebgorges
6 years ago

  • Milestone changed from Awaiting Review to 2.2

#2 @boonebgorges
6 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 9092:

Remove '.min' from asset when locating bp-legacy assets.

This ensures that the assets can be located when running from /src/ when the
minified files have not been built.

Props nofearinc.
Fixes #5963.

Note: See TracTickets for help on using tickets.