#5943 closed enhancement (fixed)
BP Groups Hooks Documentation
Reported by: | tw2113 | Owned by: | |
---|---|---|---|
Milestone: | 2.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Core | Keywords: | |
Cc: |
Description
This ticket will be where all BP Groups patches go for the Hooks Documentation.
Relevant files:
bp-groups-actions.php
bp-groups-activity.php
bp-groups-admin.php
bp-groups-adminbar.php
bp-groups-cache.php
bp-groups-classes.php
bp-groups-filters.php
bp-groups-forums.php
bp-groups-functions.php
bp-groups-loader.php
bp-groups-notifications.php
bp-groups-screens.php
bp-groups-template.php
bp-groups-widgets.php
Change History (29)
#1
@
10 years ago
- Milestone changed from Awaiting Review to Future Release
- Type changed from enhancement to task
#2
@
10 years ago
Not sure how we want to handle the following:
add_meta_box( $screen['slug'], $screen['name'], create_function( '', 'do_action( "bp_groups_admin_meta_box_content_' . $this->slug . '", ' . $group_id . ' );' ), get_current_screen()->id, $screen['metabox_context'], $screen['metabox_priority'] );
#8
follow-up:
↓ 11
@
10 years ago
We have a small case of duplicate hook names with no direct way to differentiate between the two. The hook is "loop_end" in bp-groups-template.php and is used for both the Members and the Invites methods.
Thoughts on how to handle this? Pass in a string indicating which is being associated at that moment? Graceful renaming of one or both of them?
#9
@
10 years ago
While we're in this file, we have the same situation with loop_start for both Members and Invites.
This ticket was mentioned in Slack in #buddypress by tw2113. View the logs.
10 years ago
#11
in reply to:
↑ 8
@
10 years ago
Replying to tw2113:
We have a small case of duplicate action hook names with no direct way to differentiate between the two. The hook is "loop_end" in bp-groups-template.php and is used for both the Members and the Invites methods.
Thoughts on how to handle this? Pass in a string indicating which is being associated at that moment? Graceful renaming of one or both of them?
We can't rename them. It would be fine to pass an additional parameter - $this
would make the most sense, as the loop type can be inferred from the template object. Let's do this as part of a separate ticket, please, as it's not directly related to documentation.
Moving into Future Release; we can keep these here and move them into particular releases' milestones as we commit things (or work on them).