Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 4 years ago

Last modified 3 years ago

#5924 closed enhancement (fixed)

Minor invitation template adjustment

Reported by: dcavins Owned by: dcavins
Milestone: 2.3 Priority: low
Severity: minor Version: 2.1
Component: Templates Keywords: has-patch needs-testing dev-feedback
Cc:

Description

Moves the nonce and submit button out of invites-loop.php (that is the piece that is refreshed if using bp-legacy) to the wrapper file send-invites.php.

Attachments (1)

5924.01.patch (1.4 KB) - added by dcavins 5 years ago.

Download all attachments as: .zip

Change History (11)

@dcavins
5 years ago

#1 follow-up: @DJPaul
5 years ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 2.2

If someone has modified one template file in their theme, they could end up with two submit button. I am inclined to think we should leave this alone unless @dcavins you have a good reason as to why we should make the change (I acknowledge it's what the template ought to have been like originally).

#2 in reply to: ↑ 1 @dcavins
5 years ago

Replying to DJPaul:

If someone has modified one template file in their theme, they could end up with two submit button. I am inclined to think we should leave this alone unless @dcavins you have a good reason as to why we should make the change (I acknowledge it's what the template ought to have been like originally).

Yes, there's the possibility of users having modified one or the other template parts and getting no submit buttons or two. Happily, that problem would be somewhat obvious at least.

I have no good reason beyond too much is happening in the AJAX request and recreating the submit button/nonce could cause heartache if a user is trying to bind javascript to those DOM objects. That said, it would be nice to fix but isn't currently breaking anything.

#3 @DJPaul
5 years ago

  • Keywords dev-feedback added

#4 @DJPaul
5 years ago

Need more dev opinion on whether we should make this change or not, please.

#5 @boonebgorges
5 years ago

I lean toward going with the fix suggested by dcavins. It's going to be an extremely small number of BP installations that have overridden one but not both of these templates.

#6 @DJPaul
5 years ago

  • Milestone changed from 2.2 to 2.3

#7 @DJPaul
4 years ago

@dcavins if this patch still applies, I think consensus is that you can go ahead and commit it for 2.3 if you have time?

This ticket was mentioned in Slack in #buddypress by dcavins. View the logs.


4 years ago

#9 @dcavins
4 years ago

  • Owner set to dcavins
  • Resolution set to fixed
  • Status changed from new to closed

In 9854:

Change placement of invite nonce and submit.

Move the nonce input and the submit button out of
invites-loop.php (which is refreshed when new
invitations are created or existing invites are
removed) to the wrapper file send-invites.php.

Fixes #5924.

#10 @DJPaul
3 years ago

  • Component changed from Appearance - Template Parts to Templates
Note: See TracTickets for help on using tickets.