Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#5888 closed defect (bug) (fixed)

buddypress.css being overridden after 2.1 update

Reported by: henry.wright Owned by: imath
Milestone: 2.1.1 Priority: normal
Severity: normal Version: 2.1
Component: Appearance - Template Pack Keywords: has-patch commit
Cc: hugoashmore@…

Description

There has been some reports in the forum of the 2.1 update overriding buddypress.css

See here for details:
http://buddypress.org/support/topic/my-customs-styles-stopped-work/

I'm unable to confirm because I'm away from my computer for a few days but thought it is worth highlighting the issue here.

Attachments (2)

5888.01.patch (1.6 KB) - added by r-a-y 5 years ago.
5888.02.patch (1.9 KB) - added by imath 5 years ago.

Download all attachments as: .zip

Change History (12)

#1 @r-a-y
5 years ago

  • Component changed from Core to Template Pack
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 2.1.1

This is a side-effect of #5615 where we minified all our assets.

Attached patch changes the locate_asset_in_stack() method in bp-legacy so it does not look for minifed assets in parent and child themes.

Last edited 5 years ago by r-a-y (previous) (diff)

@r-a-y
5 years ago

#2 @DJPaul
5 years ago

  • Keywords commit added

Looks good, nice catch.

#3 @DJPaul
5 years ago

  • Version set to 2.1

#4 @hnla
5 years ago

  • Cc hugoashmore@… added

#5 @shpitzyl
5 years ago

There is a problem with the patch (5888.01)

The line:

$retval['location'] = trailingslashit( $location['uri'] ) . trailingslashit( $subdir ) . $file; 

Should be:

$retval['location'] = trailingslashit( $location['uri'] ) . trailingslashit( $subdir ) . $location['file'];

#6 @r-a-y
5 years ago

Nice catch, shpitzyl!

@imath
5 years ago

#7 @imath
5 years ago

5888.02.patch is 5888.01.patch corrected according to shpitzyl comment. r-a-y do you confirm it's good to go ?

#8 @imath
5 years ago

In 9064:

Make sure themes can override BuddyPress stylesheet.

Since version 2.1, BuddyPress minified stylesheet is used if SCRIPT_DEBUG is not set. This was preventing themes to override the stylesheet using a file named buddypress.css. This patch make sure that if a buddypress.css file is located in one of the allowed css subfolder it will override the one provided by BuddyPress.

props r-a-y, shpitzyl

See #5888 (branch 2.1)

#9 @imath
5 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 9065:

Make sure themes can override BuddyPress stylesheet.

Since version 2.1, BuddyPress minified stylesheet is used if SCRIPT_DEBUG is not set. This was preventing themes to override the stylesheet using a file named buddypress.css. This patch make sure that if a buddypress.css file is located in one of the allowed css subfolder it will override the one provided by BuddyPress.

props r-a-y, shpitzyl

Fixes #5888 (trunk)

This ticket was mentioned in Slack in #buddypress by henrywright. View the logs.


5 years ago

Note: See TracTickets for help on using tickets.