Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 22 months ago

#5770 closed enhancement (maybelater)

Change "commented on the post" to something more agnostic

Reported by: Prometheus Fire Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.0
Component: Blogs Keywords: 2nd-opinion, i18n-change, trac-tidy-2018
Cc:

Description

With the increased use of custom post types when using BP, getting all the bits and pieces of integration for proper activity stream recording into place takes a bit of work.

One of the several issues that site builders struggle with is getting CPTs and their related data displaying nicely (and relevantly) in the activity stream.

I know there is ongoing work on the CPT themselves, but the comments is another aspect.

How about changing the text "%1$s commented on the post, %2$s" in bp-blogs/bp-blogs-activity.php to something simpler and more agnostic such as "%1$s comment on %2$s".

This is a very clean and simple change, but opens up a variety of possibilities when it comes to deeply integrating CPTs into the activity stream. By removing two word, a situation is created where site devs can avoid having to write several lines of code to customize the text string when recording to the activity stream.

Change History (4)

#1 @Prometheus Fire
5 years ago

  • Component changed from Core to Blogs
  • Keywords dev-feedback added
  • Type changed from defect (bug) to enhancement
  • Version set to 2.0

I don't know how to submit a patch for review and integration but this is the code change I'm talking about:

bp-blogs/bp-blogs-activity.php line 194:

Change from

if ( is_multisite() ) {
	$action  = sprintf( __( '%1$s commented on the post, %2$s, on the site %3$s', 'buddypress' ), $user_link, $post_link, '<a href="' . esc_url( $blog_url ) . '">' . esc_html( $blog_name ) . '</a>' );
 } else {
	$action  = sprintf( __( '%1$s commented on the post, %2$s', 'buddypress' ), $user_link, $post_link );
	}

Change to:

	if ( is_multisite() ) {
		$action  = sprintf( __( '%1$s commented on: %2$s, on the site %3$s', 'buddypress' ), $user_link, $post_link, '<a href="' . esc_url( $blog_url ) . '">' . esc_html( $blog_name ) . '</a>' );
	} else {
		$action  = sprintf( __( '%1$s commented on: %2$s', 'buddypress' ), $user_link, $post_link );
	}

#2 @DJPaul
5 years ago

  • Keywords 2nd-opinion i18n-change added; dev-feedback removed
  • Milestone changed from Awaiting Review to Future Release

Apart from those colons which have erroneously replaced the comma, I wonder if this change would have any impact (good or bad) on the string when it's translated to another language: I think we need some feedback before we consider making this change.

#3 @DJPaul
22 months ago

  • Keywords trac-tidy-2018 added

We're closing this ticket because it has not received any contribution or comments for at least two years. We have decided that it is better to close tickets that are good ideas, which have not gotten (or are unlikely to get) contributions, rather than keep things open indefinitely. This will help us share a more realistic roadmap for BuddyPress with you.

Everyone very much appreciates the time and effort that you spent sharing your idea with us. On behalf of the entire BuddyPress team, thank you.

If you feel strongly that this enhancement should still be added to BuddyPress, and you are able to contribute effort towards it, we encourage you to re-open the ticket, or start a discussion about it in our Slack channel. Please consider that time has proven that good ideas without contributions do not get built.

For more information, see https://bpdevel.wordpress.com/2018/01/21/our-awaiting-contributions-milestone-contains/
or find us on Slack, in the #buddypress channel: https://make.wordpress.org/chat/

#4 @DJPaul
22 months ago

  • Milestone Awaiting Contributions deleted
  • Resolution set to maybelater
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.