Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 3 years ago

#5765 closed enhancement (fixed)

atreply (maybe also hashtags?) Classes

Reported by: SGr33n Owned by:
Milestone: 2.7 Priority: normal
Severity: normal Version:
Component: Activity Keywords: needs-patch good-first-bug
Cc:

Description

Hi people :)

I just realized that maybe atreply hrefs could have a class? The best format, in my opinion could be:

<a href="#" class="atreply"><s>@</s>sgr33n</a>

Change History (3)

#1 @DJPaul
5 years ago

  • Component changed from Core to Activity
  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to Future Release

It took me a while to track down the function where we do this, so: bp_activity_at_name_filter().

I think the suggestion is fine. Let's call the class bp-suggestions-mention, as one day, we're likely to have other types of @mentions (think perhaps cross-posting to groups, or hashtags) and it would nice to name these things in the same pattern.

#2 @DJPaul
3 years ago

For legacy reasons which probably need addressing sometime, we store the at-mentions expanded in the DB (i.e. linked in anchor tags). So adding the class here won't affect existing activity content, only new content. But, it'll provide for future consistency, and if/when we switch to storing the at-mention name in the DB rather than the link, the fix will already be there.

#3 @DJPaul
3 years ago

  • Milestone changed from Future Release to 2.7
  • Resolution set to fixed
  • Status changed from new to closed

Done in r10958

Note: See TracTickets for help on using tickets.