Problem with log out link

[slaFFik]

Install WordPress a bit differently, than usual: in a subdir. So wp-admin and wp-includes folders are in lets say /wp folder. Move wp-content out of /wp folder - one level up. So now home_url() is http://site.com and site_url() is http://site.com/wp.

From this time Log out links generated by BuddyPress in (for example) wp-admin area Menu page will not work as expected. Log out link will generate a default redirect url to site_url(), which is wrong, and should be home_url().

Also in different part of the BuddyPress code different param is used for wp_logout_url(), which is not good.

[boonebgorges]

Is this a problem with wp_logout_url(), or is the problem that BP doesn't always use wp_logout_url() when it should?

[slaFFik]

The problem is with the parameter that you (in general, not personally you) pass to wp_logout_url(). It should not be always site_url(), but better home_url() instead. And sometimes you use wp_guess_url(). So it might be a good idea just to stack with 1 version, like the latter one.

[r-a-y]

slaFFik - Let me know if 01.patch fixes your problem. We don't really use site_url() any more, but wp_guess_url() does, so I switched all instances of wp_guess_url() to bp_get_requested_url(), which is better and should detect the correct URL.

[boonebgorges]

+1 from me, if it fixes slaFFik's problem.

[r-a-y]

In 8680:

Replace wp_guess_url() with bp_get_requested_url().

wp_guess_url() doesn't work well with subdirectory installs and anyway,
bp_get_requested_url() is superior!

Fixes #5737.