Skip to:
Content

BuddyPress.org

Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#5580 closed defect (bug) (fixed)

Redirects to wrong user's profile page after successful avatar crop

Reported by: mugwumpman Owned by: djpaul
Milestone: 2.1 Priority: normal
Severity: minor Version: 2.0
Component: Media Keywords: good-first-bug needs-patch
Cc:

Description

In Buddypress 1.9 you implemented a bit of code that redirects a user to their profile page after a successful avatar crop. It's a great idea, but very annoying if you are an admin editing a different user's avatar. Instead of getting redirected to their profile after the avatar crop, you get redirected to your own profile every time. Can this code be changed so it's relative to the avatar that's just been cropped?

This is a follow-up to #5150. Many thanks, Matt

Attachments (1)

bp-xprofile-screens.php.patch (511 bytes) - added by milesstewart88 5 years ago.
Redirect Patch

Download all attachments as: .zip

Change History (5)

#1 @boonebgorges
5 years ago

  • Keywords good-first-bug needs-patch added
  • Milestone changed from Awaiting Review to 2.1

Yup, good call.

@milesstewart88
5 years ago

Redirect Patch

#2 @milesstewart88
5 years ago

Uploaded a patch for this ticket. Simple fix gone through with Paul at WordCamp Sheffield.

#3 @djpaul
5 years ago

  • Owner set to djpaul
  • Resolution set to fixed
  • Status changed from new to closed

In 8322:

xProfile: fix redirect when an admin uploads an avatar to another user's profile.

When cropping a new avatar, a redirect always took you to the logged-in user's profile.
This was fine in most situations, as a user can only update their own profile.
However, site admins are able to edit other users' profiles, so we need to redirect to the displayed user's profile.

Fixes #5580, props milesstewart88

#4 @DJPaul
3 years ago

  • Component changed from API - Avatars to Media
Note: See TracTickets for help on using tickets.