Notice appears when using BP Nav Menus

[alnasirkarim]

Warning: strpos() [function.strpos]: Empty needle in /home/content/92/7143392/html/reunion/wp-content/plugins/buddypress/bp-core/bp-core-filters.php on line 489

Site: Reunion.tamakboys.net
Buddypress version: 1.9.2
WP version 3.8.3

[DJPaul]

What URL did you access to trigger this error?

[alnasirkarim]

It show up on the home page in the menu bar.

[r-a-y]

alnasirkarim - This occurs when you have deactivated a BuddyPress component, but you still have the menu item for the deactivated component listed under "Appearance > Menus":
http://buddypress.org/support/topic/error-message-warning-strpos-function-strpos-empty-needle-in/#post-176804

I've attached a patch, which fixes the notice from displaying.

It doesn't remove the deactivated component's menu item though. What we could do in an iterative patch is when deactivating a component, check the BP menus and remove the offending menu item.

Core devs: Okay for v2.0.1?

[boonebgorges]

Good find, r-a-y. Yes, this looks safe for 2.0.1.

[alnasirkarim]

Thank you r-a-y.

It worked.

[r-a-y]

I still need to commit the fixes ;)

[r-a-y]

In 8307:

BP Nav Menu: If menu URL doesn't exist, mark menu item as invalid.

Previously, when a BuddyPress component is deactivated but a menu item
for this component still exists, the generated menu would create a warning.

This commit addresses this.

See #5545 (2.0-branch)

[r-a-y]

In 8308:

BP Nav Menu: If menu URL doesn't exist, mark menu item as invalid.

Previously, when a BuddyPress component is deactivated but a menu item
for this component still exists, the generated menu would create a warning.

This commit addresses this.

Fixes #5545 (trunk)