Return results for bp_[update|delete]_option()

[slaFFik]

I'm on BuddyPress beta.
Currently only bp_add_option() return the result of native WordPress function.

Could you please add return for bp_update_option() and bp_delete_option() as well?

Thanks in advance.

[slaFFik]

I see that you already using this like this:

if ( !bp_update_option( $key, $bp->site_options[ $key ] ) ) {
    $errors = true;
}

But this results in errors in PHPStorm, as nothing explicitly returned but the function.

[boonebgorges]

Yes, let's do this, but it's late to do it for BP 2.0.

[slaFFik]

1.9.3? I see 2 tickets closed there :)

Anyway, thanks for accepting.

[boonebgorges]

These functions have acted this way since they were introduced in BP 1.5, so the issue you raise is not a regression in 2.0. And while it's very unlikely that adding return values is going to break anything, it's not impossible. And it's unwise to make changes with breaking potential at this point in the dev cycle (for either 2.0 or 1.9.x) for non-regressions. Thus the 2.1 milestone :)

[slaFFik]

You won. Hat's off

[DJPaul]

Patch is OK assuming we are fine changing the return types.

[boonebgorges]

In 8668:

Return values from bp_*_option() functions.

Fixes #5518

Props slaFFik