Opened 11 years ago
Closed 11 years ago
#5479 closed enhancement (fixed)
Messages: Better notification formatting and marking
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 2.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Messages | Keywords: | has-patch |
Cc: |
Description (last modified by )
This ticket stems from ticket:5273#comment:33.
It reformats the notification for new messages and clears them when the user visits the actual message thread instead of the message inbox.
Patch also fixes a bug with a user's notification cache not being cleared when a notification is marked as either read or unread.
Attachments (1)
Change History (4)
Note: See
TracTickets for help on using
tickets.
Is there a reason you're doing this
instead of this
?
I assume it's just a half-finished idea :)
bp_messages_screen_inbox_mark_notifications()
should be properly deprecated if you're going to use a different technique for clearing.A unit test for the failed cache busting would be truly delightful, but is not a deal-breaker.
Otherwise the changes look good. Thanks!