xprofile Administration - js do not reset options when [x] clicked

[imath]

Hi,

While testing #5220, i've found that when creating/editing a field with options to set (radio / checkbox / selectbox..). If you add some text in the option field, then click on [x] link, the field is hidden, but the value is not removed. As a result when saving / updating the field, the "removed" option is saved.

I think it's a js issue due to the fact the id of the field is different thant the id of the container div. I suggest the attached diff to solve it.

[DJPaul]

Good find. I've confirmed this exist all the way back to 1.5 (it wasn't easy to go much further back).

[r-a-y]

Looks good!

[imath]

In 8180:

In Profile fields management screens, make sure the cancelled field options are not saved

When editing fields using options such as select boxes, radio boxes, check boxes, etc. when an admin cancelled one or more options, they were still saved. This make sure cancelled options are fully removed before the profile field is edited.

Fixes #5453