Skip to:
Content

BuddyPress.org

Opened 6 years ago

Closed 5 years ago

#5345 closed defect (bug) (fixed)

WordPress Show Avatars settings and Avatar in Group Component

Reported by: imath Owned by: imath
Milestone: 2.1 Priority: normal
Severity: normal Version: 1.0
Component: Groups Keywords: has-patch commit
Cc:

Description

If in WordPress Administration > discussion panel, the show avatars option is disabled, i think we should avoid to load the different areas that deal with group avatars, such as :

  • the avatar creation step
  • the admin > avatar subtab in the edit screen
  • the links to go to the change avatar admin tab in WP Admin Bar

There's also a trouble with $groups_template->group->avatar_thumb in bp_get_group_avatar() function, in this case.

Attachments (2)

5345.diff (4.5 KB) - added by imath 6 years ago.
5345.02.patch (5.1 KB) - added by imath 5 years ago.

Download all attachments as: .zip

Change History (9)

@imath
6 years ago

#1 @boonebgorges
6 years ago

Yes, this makes sense, especially since all calls to bp_core_fetch_avatar() will fail when avatar display is disabled in this way.

Should we also be doing something similar for the xprofile component?

#2 @DJPaul
6 years ago

  • Keywords needs-refresh added; 2nd-opinion removed
  • Milestone changed from Awaiting Review to 2.1
  • Version changed from 1.9.1 to 1.0

Moving to 2.1 to finish up the patch for this new switch to work across all components.

#3 @imath
5 years ago

I think it's ok for Members/xprofile component since r7747

5345.02.patch is a refresh version of initial patch for this ticket.

@imath
5 years ago

#4 @imath
5 years ago

  • Keywords needs-refresh removed

This ticket was mentioned in IRC in #buddypress-dev by paulgibbs. View the logs.


5 years ago

#6 @DJPaul
5 years ago

  • Keywords commit added

Not tested, but the patch looks OK.

#7 @imath
5 years ago

  • Owner set to imath
  • Resolution set to fixed
  • Status changed from new to closed

In 8737:

Disable Group avatar feature if WordPress show avatars setting is disabled

In WordPress Administration Discussion settings, if the option "Show Avatars" is not on, we need to disable the Group Avatar feature to avoid some notices and be consistent with the discussion option.

Fixes #5345
See #5494

Note: See TracTickets for help on using tickets.