Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 10 years ago

#5256 closed enhancement (fixed)

Settings component WP Admin Bar Notifications Submenu

Reported by: imath's profile imath Owned by: boonebgorges's profile boonebgorges
Milestone: 1.9 Priority: normal
Severity: minor Version: 1.8.1
Component: Settings Keywords: has-patch
Cc:

Description

Sorry in #5240 i forgot to talk about the WP Admin Bar, i think the settings Notifications submenu should also be changed in favor of "Email".

I suggest the diff attached to this ticket

Attachments (1)

5256.diff (553 bytes) - added by imath 10 years ago.

Download all attachments as: .zip

Change History (5)

@imath
10 years ago

#1 follow-up: @henrywright
10 years ago

Hi imath, perhaps plural 'emails' would be better?

#2 in reply to: ↑ 1 @imath
10 years ago

Replying to henrywright:

Hi imath, perhaps plural 'emails' would be better?

Hi Henry,
As the bp nav uses "Email", i've suggested the same term for WP Admin Bar. If "Emails" is best for WP Admin Bar, then it might also be best for bp nav (#5240).

#3 @boonebgorges
10 years ago

  • Milestone changed from Awaiting Review to 1.9
  • Severity changed from normal to minor

To my American ear, "Emails" sounds wrong when we're talking about the settings related to email. Let's stick with that, unless there's overwhelming evidence that the plural would be better. (And if it's a Britishism, let's put it in en_GB)

#4 @boonebgorges
10 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7602:

Use 'Emails' instead of 'Notifications' in Settings admin bar menu

This mirrors the changes introduced in #5240

Fixes #5256

Props imath

Note: See TracTickets for help on using tickets.