Beta 1.9 Fatal Error if BuddyPress folder is renamed

[trishasalas]

bp-core/bp-core-wpabstraction.php will not load (fatal error, file can't be found) if the BuddyPress folder is named anything other than BuddyPress. Admittedly and edge case but as I had 3 different BuddyPress folders in my downloads folder 'BuddyPress 3' was just not going to work. :)

I've duplicated this twice.

[r-a-y]

Give this patch a try and let me know if it fixes your problems.

[trishasalas]

That fixed it! ....and this is a much more elegant solution than renaming the folder :)

Thanks, @r-a-y

[r-a-y]

Thanks for testing, trishasalas.

I don't think this will break anything, but just need a sanity check from another core dev before committing.

[johnjamesjacoby]

In 7601:

Use plugin_dir_path() rather than hardcoded buddypress directory name. Props r-a-y. Fixes #5252.

[johnjamesjacoby]

For context, I believe it was originally hardcoded because of it possibly living in the mu-plugins directory. Since switching to using the WP_PLUGINS_DIR constant, that option disappeared anyways, so using plugin_dir_path() is now the best function for the job.

Since it's a variable in the class, it can be optionally overridden, though I'm finding that doing so isn't as easy as I'd originally hoped, and I'll likely open a new ticket to address this in a future milestone.