IE8 bug in global.js (String.prototype.trim is undefined)

[tomdxw]

I couldn't find any information on what browsers BuddyPress supports, so I don't know if this is a valid bug or not, but I'll report it anyway.

1. Use IE8, with BuddyPress and the bp-default theme activated
2. Visit a group
3. Type something into the "what's new" box
4. Click "Post Update"
5. IE8 reports an error on line 1502 of global.js and the post is not submitted

To fix I simply added this polyfill: ​https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/trim#Compatibility

[boonebgorges]

Thanks for the report. Adding the polyfill seems reasonable if it fixes the issue.

r-a-y, as our resident IE8 expert, could you have a look?

[r-a-y]

Tested and bug confirmed. Thanks tomdxw for reporting.

Instead of using the polyfill, I'm going to use jQuery's trim() function instead since jQuery already has a trim function and we already have jQuery loaded.

[r-a-y]

In 7443:

JS: Replace String.trim() method with jQuery's trim() function.

When using IE8 and when attempting to post an activity update, IE8
will throw an error and not post the update because of the usage of
String.trim(), which does not exist in IE8.

To fix this bug, we replace String.trim() with jQuery's version of
trim().

Props tomdxw for reporting the bug.

Fixes #5205.