Skip to:
Content

BuddyPress.org

Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#5107 closed enhancement (fixed)

Components pagination count singular/plural enhancement

Reported by: imath Owned by: boonebgorges
Milestone: 1.9 Priority: normal
Severity: minor Version: 1.8
Component: I18N Keywords: has-patch needs-testing
Cc:

Description

Hi,

I've noticed that the different component when only 1 item was existing the plural form was used. It's a very minor enhancement, but i think it would be better to have for instance :
"Viewing item 1 to 1 (out of 1 item)" instead of "out of 1 items".

I've also noticed that the single member group invite screen was using bp_group_total_members() instead of bp_get_group_total_members().

In the attached diff, my suggestion about singular/plural forms in components pagination count.

Attachments (1)

5107.diff (9.6 KB) - added by imath 7 years ago.

Download all attachments as: .zip

Change History (5)

@imath
7 years ago

#1 @boonebgorges
7 years ago

  • Milestone changed from Awaiting Review to 1.9

Looks good at a glance. Let's do it for 1.9.

#2 @boonebgorges
7 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 7439:

Improved plural i18n for pagination links

Cases where there is only one page of results will now read, eg, "...of 1
member" instead of "...of 1 members".

Where the pagination links are put through apply_filters(), this changeset
also adds the passing of the $from_num, $to_num, and $total values to the
filter.

Fixes #5107

Props imath

#3 @johnjamesjacoby
6 years ago

  • Component changed from Component - Any/All to Locale

#4 @DJPaul
4 years ago

  • Component changed from Locale to I18N
Note: See TracTickets for help on using tickets.