Skip to:
Content

Opened 9 months ago

Closed 5 months ago

#5105 closed defect (bug) (fixed)

Group Admin UI Bulk Deleting groups just refresh group list

Reported by: imath Owned by: r-a-y
Milestone: 1.9 Priority: normal
Severity: normal Version: 1.7
Component: Groups Keywords: has-patch
Cc:

Description

Hi,

I'm really sorry i haven't noticed this before 1.8 release :(

When on Group Admin UI, if you select 1 or more group and try to bulk delete it/them, it only refreshes the group list.

The first problem is that the name of the checkbox is aid[], the second problem is that the action is not set to delete once in the function bp_groups_admin().

I sugget the diff attached to this ticket as it seems to restore the bulk delete process.

Attachments (1)

5105.diff (1.0 KB) - added by imath 9 months ago.

Download all attachments as: .zip

Change History (12)

imath9 months ago

comment:1 imath9 months ago

  • Component changed from Core to Groups

comment:2 imath9 months ago

  • Version changed from 1.8-beta to 1.8

comment:3 boonebgorges9 months ago

  • Milestone changed from Awaiting Review to 1.9

comment:4 mercime8 months ago

Same here. Can delete groups individually but bulk delete is not working for single WP site nor for WP multisite install in wp-admin Group Admin UI. Just tested this when someone reported the issue in the BP forums.

Last edited 8 months ago by mercime (previous) (diff)

comment:5 r-a-y8 months ago

  • Owner set to r-a-y
  • Resolution set to fixed
  • Status changed from new to closed

In 7360:

In the groups dashboard, fix bulk deletion. Fixes #5105.

  • Use bp_admin_list_table_current_bulk_action() to reconcile what the proper action is when doing a bulk action like deleting.
  • Fix copypasta from activity admin dashboard to use group IDs.

Props imath.

comment:6 r-a-y8 months ago

  • Keywords needs-testing removed
  • Version changed from 1.8 to 1.7

Thanks imath for the patch! Sorry it took so long to get this committed.

Last edited 8 months ago by r-a-y (previous) (diff)

comment:7 j.conti6 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Version changed from 1.7 to 1.8.1

Hi,

I don´t know if it was fixed, but with WordPress Multisite 3.6.1 + BuddyPress 1.8.1 it happens again (I don't tested with WordPress, only with Multisite)

If you want to do a Bulk group deletion, the group screen is refreshed without remove the groups.

I dont know if I had to open a new ticked, but @boonebgorges tell me that ping the ticket.

comment:8 j.conti6 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Version changed from 1.8.1 to 1.7

Sorry, the Trunk version works.

comment:9 follow-up: j.conti6 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Hi again,

After some testing, I think there is more to fix.

If I change from show 20 groups to 200 (ex.) at Groups admin screen, I can see the latest 200 created groups.

If a select all groups (200 groups) and I want to delete them with the bulk action, are only deleted the first 20 groups, so the Bulk action is not sending all groups.

Tested with the latest trunk version.

comment:10 in reply to: ↑ 9 ds1235 months ago

thank you for working on this .... any idea on when it could be fixed?

i'm trying to delete over 30,000 spam groups from a live site so really could use this unless there is a mysql alternative process ?

comment:11 boonebgorges5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 7582:

Process all groups being deleted from the admin, not just the default per_page 20

Fixes #5105

Note: See TracTickets for help on using tickets.