bp_nav_menu activity favorite filter selection clash with bbPress favorites

[hnla]

There could be a potential issue with bbPress grabbing / hijacking the favourites submenu.

Clicking Activity > Favourites has the effect of setting the forum parent li element to the class 'current-menu-parent' where only the activity li element should have this. Result in my implementation is the submenu elements are overwriting the activity submenu items due to the class on forums li set to 'current-menu-parent'

For reference wp_nav_menus discussed and added in #4629

[johnjamesjacoby]

This looks okay to me. If I'm incorrect regarding which menu you're speaking of, can you include a screenshot to help identify the issue?

[hnla]

If I'm incorrect regarding which menu you're speaking of

It's the newish bp_nav_menu() so isn't in general use so far as it needs to be implemented in templates to replace old object nav

You would need to do:

<div id="item-nav">
  <div class="item-list-tabs no-ajax" id="object-nav" role="navigation">
    <?php bp_nav_menu(); ?>
  </div>
</div>

In /members/home.php & removing the subnav calls

I ran up a set of template files & styles when I was test implementing the menu which can be used if easier:

​https://github.com/hnla/hnla-bp-nav-menu/tree/master

The issue is then as described in opening ticket selecting activity>friends would set that link to 'current' but forums link also receives the class 'current' causing issues with styles.

[hnla]

menu view normal

[hnla]

menu view broken

[hnla]

menu markup view showing current item classes

[hnla]

menu markup expanded

[johnjamesjacoby]

Replying to hnla:

It's the newish bp_nav_menu() so isn't in general use so far as it needs to be implemented in templates to replace old object nav

This is helpful, and I confirmed it just now.

We use this on buddypress.org, and you can see it happen on your own profile.

[johnjamesjacoby]

Moving to 1.9, so we can lump this in with other navigation API updates. Related to #5103.

[hnla]

We use this on buddypress.org, and you can see it happen on your own profile.

Ah yes, just had a look, never realised it was in use anywhere :)

[lakrisgubben]

The problem is that the current implementation of bp_get_nav_menu_items only checks if the submenu slug is the same as bp_current_action which leads to false positives if two different components have submenus that use the same slug (like favorites). The attached patch fixes this by also checking that the parent menu item has the same slug as the current component.

[hnla]

Thanks for patch, lets review and fix for 2.9, be nice to close out a four year old ticket. :)

[boonebgorges]

@lakrisgubben Good catch! Fix looks right to me.

[boonebgorges]

In 11518:

Better current-item determination in bp_nav_menu().

Current component *and* action should both be matched when
determining current item, so as to avoid clashes when two
top-level items have children by the same name.

Props lakrisgubben.
Fixes #4986.