Skip to:

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#4854 closed defect (bug) (fixed)

Old forums in 1.7 and Theme Compat

Reported by: imath's profile imath Owned by:
Milestone: 1.7 Priority: normal
Severity: blocker Version: 1.7
Component: Forums Keywords: has-patch



I think the case of old forums (bbPress 1.0) needs to be discussed. I was writing a tutorial for 1.7 and simulated an upgrade from 1.6.4. Everything went great !!

On my "old" 1.6.4 config, i had old forums activated (bbPress 2.3 is not installed on this testing config). I know it's "retired", but when users will upgrade, they may be surprised if they don't find their 'Forums Directory' !!
That's what happened to me :)
The directory page disappeared from the wp_nav_menu, but was still there using bp-default and clicking on the 'Forums directory' link in the group's subnav forums/single/topic template.

Then i activated twentytwelve and noticed that the link in the group's subnav forums/single/topic template is still there, but when i clicked on it, i arrived on the empty WordPress page that is associated with the old forum component.

Then i went in bp-forums-screens.php and saw that the BP_{component}_Theme_Compat class wasn't there.
Then i went in bp-core-filters.php and understood why my 'Forums Directory' nav disappeared from my wp_nav_menu :)

So i said to myself, old forums are not available in BP Theme Compat.. But i also thought, we should then avoid adding a link to the group's subnav forums/single/topic template as shown in the image i attached to this ticket. And i was a bit confused when i saw that BP Legacy was containing a buddypress/forums/index.php template.

So, i made this test :

  • i've put back the forum condition of 1.6.4 in 1.7-beta1 bp_core_exclude_pages function in bp-core-filters.php,
  • added a BP_{component}_Theme_Compat class,
  • modified the BP Legacy's buddypress/forums/index.php template to include a div with the id of buddy press.

Then i've run it, and it worked.

So i thought, the case of 'old forums in BP Theme Compat' should be discussed, as bbPress 2.3beta2 is doing a really nice job in BuddyPress Group forums (except for the sticky trouble, wrote a ticket on bbPress trac about it..).

If the option is to still take care of old forums in BP Theme Compat, then it'll need, as for admin global notices (see #4802), to think about the "tag widget" that is hardcoded in bp-default's sidebar.

Finally, i haven't tested what's happening if bbPress 2.3 is activated..

Attachments (2)

4854.diff (13.9 KB) - added by imath 11 years ago.
forum-directory.png (101.0 KB) - added by imath 11 years ago.
group's subnav using BP Theme Compat

Download all attachments as: .zip

Change History (6)

11 years ago

11 years ago

group's subnav using BP Theme Compat

#1 @boonebgorges
11 years ago

  • Milestone changed from Awaiting Review to 1.7
  • Severity changed from major to blocker

Thanks for the report and for the patch, imath.

IMO this is a blocker. We should be providing at least minimal support to existing installations that want to use theme compat.

I'll check out the patch later today.

#2 follow-up: @boonebgorges
11 years ago

  • Keywords 2nd-opinion needs-testing removed

The patch looks really excellent. Thanks again, imath.

I've made a few tweaks and will commit momentarily.

#3 @boonebgorges
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6827]) Enables theme compat for legacy bbPress 1.x forum content

  • Don't exclude top-level forum directory page from wp_nav_menu() as long as forums are correctly installed
  • Introduces BP_Forums_Legacy_Theme_Compat
  • Tweaks forum directory table styling

Fixes #4854

Props imath

#4 in reply to: ↑ 2 @imath
11 years ago

Replying to boonebgorges:

The patch looks really excellent. Thanks again, imath.

I've made a few tweaks and will commit momentarily.

Thanks Boone :)
"C'est génial !"

Note: See TracTickets for help on using tickets.