Include username in notification emails

[sooskriszta]

When a user registers as member, they are sent an account activation link in an email.

That email should also include the username.

In fact, all email notifications should include the username.

[sooskriszta]

In 1.8 please? Shouldn't take more than 10 mts to edit code and upload patch (in my imagination) :-P

[boonebgorges]

It takes more than that, because we don't generate these emails in some cases - WP handles registration emails on Multisite. I'm not opposed to having this in 1.8, but someone will need to patch it, and I'm not sure I will have the time in the next 8 days.

[sooskriszta]

We don't have to worry about cases where WordPress handles the emails - WordPress typically does send out usernames in notification emails. The problem is only with the messages sent out by BuddyPress.

[sooskriszta]

Of all the tickets I have bumped today, this one is the most shameless, and for that I apologize. But really, really, really hope this simple to do but important to have bit is included in 1.9

[sooskriszta]

2.0?

[boonebgorges]

I'm not opposed, but it needs a patch.

[sooskriszta]

Which files are responsible for generating the mail content? I'll try to cook up a patch. Will need a bit of handholding.

[boonebgorges]

Email notifications are generated in a variety of places throughout BuddyPress. The registration emails are built in these functions: ​https://buddypress.trac.wordpress.org/browser/tags/2.0/bp-core/bp-core-filters.php#L295

[sooskriszta]

Adds username in registration email

[DJPaul]

Thanks for the patch, however the username will need to go inside the __() call to ensure the entire string can be translated properly (look at %1$s stuff we have in the string already; these are gettext placeholders).

[tanner m]

I'd be happy to help out with the patch here. Is there a reason that updating the default message is a better solution than using a filter in this case?

[DJPaul]

Because we can just change BuddyPress here, we don't need to filter to change our own code. :)

[tanner m]

Updated the diff to include both MU and single site user registration. Also moved username within the translation function.

[sooskriszta]

Replying to DJPaul:

Thanks for the patch, however the username will need to go inside the __() call to ensure the entire string can be translated properly (look at %1$s stuff we have in the string already; these are gettext placeholders).

Ok. I thought __() stuff was just the stuff that needed translation and username doesn't. Anyway, attaching updating patch.

[sooskriszta]

Updated patch - 29 Jul 2014

[sooskriszta]

Argh! Didn't include file patch in previous.

[sooskriszta]

Updated patch 2 - 29 Jul 2014

[DJPaul]

Thanks, this looks better (2.patch). Just wanted to check that the email needed those line breaks right at the start (we don't have those currently)?

[sooskriszta]

Included the breaks as they seemed appropriate...have used the username to address the user...

DJPaul,

Thanks for registering! To complete the activation of your account...

[djpaul]

In 8743:

Core: when sending the user registration email, include the user's name in the email.

It makes the email read a bit friendlier. :) Fixes #4731

[DJPaul]

I just realised I forgot to give sooskriszta props in the commit message. I am very sorry.