Skip to:

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#4416 closed defect (bug) (no action required)

Activity Stream Comment Notifications in BP 1.6

Reported by: tmj31's profile tmj31 Owned by:
Milestone: Priority: normal
Severity: normal Version: 1.6
Component: Activity Keywords:


I’ve encountered an error that was not present prior to updating to 1.6.

Previously, if someone made an Activity Stream post, and another user commented on that post, the original author would get a BP Notification that a comment was added to their post.

This is no longer happening. After replying to a stream post, the original poster still has 0 notifications.

I do not know if this is also happening with other ‘events’ as well, but it certainly is with stream commenting.

The notifications are not being displayed either in the new "Notification Box" in the WP Admin Bar (new to 1.6) nor in any customized widgets or code where notifications from BP are being called to display.

Change History (5)

#1 @r-a-y
12 years ago

  • Component changed from Core to Activity
  • Keywords reporter-feedback added

I don't believe BuddyPress ever had activity comment notifications.

Are you using this plugin?

#2 @r-a-y
12 years ago

  • Keywords close added; reporter-feedback removed

Just looked at the codebase and I can confirm that activity comment notifications were never added. Definitely a plugin at work; most likely it's BuddyDev's but could be another one.

So this isn't a bug, but it could be a future enhancement.

I'm leaving this ticket open for a core dev to either close or leave open as an enhancement.

#3 @sbrajesh
12 years ago

tmj31: Indeed Ray is right. The activity comment notification was never a part of BuddyPress.
if you are using my plugin, I have just pushed an update on github which you can get from here.

The problem was caused by the addition of

 if ( !bp_is_active( $component_name ) )

in line 107-108 of the bp-members-notifications.php.

The bp_is_active checkes for the active component and in old days we used to register components like

$bp->active_components[the component slug] = The component Id

which won't work and fail the check.
You will need to do something like this

$bp->active_components[the component id] = The component Id

It is only required if the plugin is not extending BP Core component class for creating component.

#4 @r-a-y
12 years ago

  • Keywords close removed
  • Resolution set to invalid
  • Severity changed from major to normal
  • Status changed from new to closed

Okay, cool! Glad that's taken care of. Thanks Brajesh!

I'm going to close this ticket for now. If the core devs want to add a new ticket to look at adding activity comment notifications in a future release, they can do so at their discretion.

#5 @DJPaul
12 years ago

  • Milestone Awaiting Review deleted

If anyone wants this, please create a new enhancement ticket, as this one's a bug ticket. Thanks.

Note: See TracTickets for help on using tickets.